-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENDOC-726-update-plugin-code #761
Conversation
* [Add an Entando Operator ConfigMap](../consume/entando-operator.md) if needed, then | ||
* Enable this property under the `data` section so that the Entando Operator can manage resource settings: | ||
```yaml | ||
entando.k8s.operator.impose.limits: "true" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why was this removed? Was this a change in 7.2?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's already there in the ConfigMap
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jyunmitch Maybe I'm missing something but I don't think it's there by default. Definitely not in the template we provide https://github.com/entando/entando-releases/blob/release/7.2/dist/ge-1-1-6/samples/entando-operator-config.yaml or in the custom resources. I think it's automatically applied by AWX when we install into PS Dev but that isn't the default config. What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nshaw, you're completely right. I assumed that our Rancher test set up would be the default one. If that's not the default one, how can I know what the customers see
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jyunmitch Great question. It might be worth asking PJ or Sergio if there's a document on how the PS Dev env differs from a stock install. That might already exist in notion. The alternative is to check a vanilla install on multipass or check the code, like I just did, but that's a pain.
@@ -80,6 +77,7 @@ data: | |||
data: | |||
entando.plugins.defaultProfile: YOUR-PROFILE-NAME | |||
``` | |||
>Note: If a resouceReguirement was specified in the plugin custom resource, that will override a profile. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
>Note: If a resouceReguirement was specified in the plugin custom resource, that will override a profile. | |
>Note: If a resourceRequirement was specified in the plugin custom resource, that will override a profile. |
No description provided.